Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a volume for Portalbackend logs. #168

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

KFilippopolitis
Copy link
Contributor

No description provided.

@KFilippopolitis KFilippopolitis requested a review from jdaln July 3, 2024 10:56
@KFilippopolitis KFilippopolitis force-pushed the portalbackend-logs-persistent branch 3 times, most recently from 4b089ba to 39814d3 Compare July 4, 2024 14:29
@KFilippopolitis KFilippopolitis force-pushed the portalbackend-logs-persistent branch from 52d1164 to 492bf5a Compare July 23, 2024 15:49
@KFilippopolitis KFilippopolitis force-pushed the portalbackend-logs-persistent branch 2 times, most recently from de484ae to b58f3cd Compare July 24, 2024 08:48
@KFilippopolitis KFilippopolitis force-pushed the portalbackend-logs-persistent branch from b58f3cd to b208969 Compare July 24, 2024 08:50
Copy link
Member

@jdaln jdaln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KFilippopolitis if my changes are ok, this can be merged

volumeMode: Filesystem
accessModes:
- ReadWriteOnce
persistentVolumeReclaimPolicy: Delete
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with Retain here. Since it's logs, we need to keep them unless we explicitely delete them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KFilippopolitis still same question

logs:
storage0:
data_path: /opt/mip-deployment/logs
data_size: 100Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of size, this needs to target 1 year of logs for now, until we have a better archival procedure in place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KFilippopolitis here too

Copy link
Contributor Author

@KFilippopolitis KFilippopolitis Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdaln there is the default mechanism of cscs that will back it up each day.

@jdaln
Copy link
Member

jdaln commented Aug 16, 2024

@ThanKarab would you know what is wrong here?

@KFilippopolitis KFilippopolitis force-pushed the portalbackend-logs-persistent branch from cb6882b to 6f108fc Compare August 23, 2024 14:08
@KFilippopolitis KFilippopolitis merged commit 79ebec8 into master Aug 23, 2024
1 check passed
@KFilippopolitis KFilippopolitis deleted the portalbackend-logs-persistent branch August 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants