Gyeeta welcomes contributions from the community. This document outlines the conventions that should be followed when making a contribution. Please read the CODE_OF_CONDUCT.md as well.
Bugs may be reported by filing a Github issue in the appropriate repository. Please follow the template when filing an issue and provide as much information as possible. Before reporting a bug, we encourage you to search the existing Github issues to ensure that the bug has not already been filed.
Please create a Github issue that details the bug or feature being addressed before submitting a pull request. In the Github issue, contributors may discuss the viability of the solution, alternatives, and considerations.
Steps to making a code contribution to any of the Gyeeta repositories will generally look like the following
- Fork the repository on Github.
- Create a new branch.
- Make your changes in organized commits.
- Push your branch to your fork.
- Submit a pull request to the original repository.
- Make any changes as requested by the maintainers.
- Once accepted by a maintainer, it will be merged into the original repository by a maintainer.
When making a contribution to the repository, please ensure that the following is addressed.
- All existing tests must pass, and new tests may be added for the bug/feature in question, if deemed necessary.
- Commits are signed (see notes below).
Commit messages should provide enough information about what has changed and why.
The sign-off is a simple line at the end of the explanation for a commit. All commits needs to be signed.
You just add a line to every git commit message:
Signed-off-by: Joe Smith <[email protected]>
Use your real name (No pseudonyms or Anonymous contributions.)
If you set your user.name
and user.email
git configs, you can sign your commit with git commit -s
.
Note: If your git config information is set properly then viewing the git log
information for your commit will look something like this:
Author: Joe Smith <[email protected]>
Date: Thu Feb 2 11:41:15 2018 -0800
Update README
Signed-off-by: Joe Smith <[email protected]>
Notice the Author
and Signed-off-by
lines match. If they don't your PR will be rejected by the automated check.