New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `DiskRefreshKind` #1387

Open

dlowe wants to merge 1 commit into GuillaumeGomez:master from dlowe:selectively-refresh-disks

dlowe commented Nov 22, 2024

fixes #1375.

add DiskRefreshKind, following the existing pattern (except that kind defaults to true)
add _specifics variants of Disk and Disks constructors and refresh methods
tweak the linux Disk and Disks to allow precise control over what gets loaded
manually tested on the targets I have access to (aarch64-linux-android, aarch64-apple-darwin, aarch64-apple-ios)

Questions / unresolved bits:

are there os-specific tests somewhere I can / should add to?
as discussed, we'll need to figure out what to do with DiskKind when the user explicitly refreshes .without_kind()
anything else I missed?

dlowe force-pushed the selectively-refresh-disks branch 2 times, most recently from 245335a to d47e355 Compare

November 22, 2024 21:36


          Add DiskRefreshKind

4068e14

dlowe force-pushed the selectively-refresh-disks branch from d47e355 to 4068e14 Compare

November 22, 2024 21:41

dlowe marked this pull request as ready for review

November 22, 2024 21:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet