Initial work on a Vector trait
#153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris00
force-pushed
the
master
branch
5 times, most recently
from
e48a6d3
to
daf1b44
Compare
|
Looks great to me! I'm not personally a user of this crate, so maybe try to check around you or in the community what they think about it? |
Added benefits to the additional generality: - all functions are bound checked; - the complex numbers are handled correctly and are compatible with their standard Rust representation.
As this trait will be requested to be brought into scope to set strides, it is good that the functions required to define its capabilities do not conflict with methods that the type may originally have.
|
The code now triggers lots of “transmute used without annotations” which are unrelated to my changes. There is still quite a bit of work to do (there are still |
|
Can you use stride crate instead of Slice/SliceMut? |
|
@hugohp Not sure what you have in mind since, here, the strides need not be const — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #147, here is some preliminary work on the introduction of a
Vectortrait (forfitandcblas::level1). (It is better to have early feedback before doing more work! In particular aStridetrait must be developed to be able to add strides to anyVectorcontainer.)Note that, as added benefits, the equality of lengths of inputs is now checked (no way of specifying a longer length than allocated) and complex numbers are handled correctly (and in a compatible way with their Rust standard representation).