Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add animation using gsap #95

Closed
wants to merge 0 commits into from
Closed

Add animation using gsap #95

wants to merge 0 commits into from

Conversation

Nikuunj
Copy link

@Nikuunj Nikuunj commented Oct 12, 2024

Description

Please include a summary of the changes and the related issue. Include relevant motivation and context.

Fixes #78

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@Nikuunj Please resolve conflicts

Anshgrover23
Anshgrover23 requested changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not try to write through AI-Generated code because you are removing every feautre from the app and that is not acceptable?? You have to just add animation to the app using GSAP library.

index.html Outdated
</button>
</div>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove app's sorting feautre?

index.html Outdated
</div>

<footer class="footer">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why did you remove the footer of the website?

script.js Outdated
@@ -186,52 +167,18 @@ function setDefaultDateTime() {
inputTimeElement.value = time;
}

function sortTodos(sortBy) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again??

@Nikuunj Nikuunj closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add animation using gsap
2 participants
@Nikuunj @Anshgrover23