Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added toggle #42

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added toggle #42

wants to merge 2 commits into from

Conversation

ayush1009208
Copy link

No description provided.

@divanshu-go
Copy link
Contributor

@ayush1009208 Please read the contributing.md file carefully and only mark the PR as ready for review when it actually it is.
drafting it until the code is ready for review

@divanshu-go divanshu-go marked this pull request as draft October 12, 2024 03:23
@ayush1009208
Copy link
Author

Amm...i didn't get that?

@divanshu-go
Copy link
Contributor

@ayush1009208 Please add the fixes #x in you PR description and also share a screenshot or recording where you show that your changes are working.

divanshu-go
divanshu-go requested changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@divanshu-go divanshu-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush1009208 Also resolve the conflicts before we test it.

@ayush1009208 ayush1009208 marked this pull request as ready for review October 13, 2024 06:17
@ayush1009208
Copy link
Author

Sorry the review initiated by mistake
I am working on the conflicts

@Anshgrover23
Copy link
Collaborator

@ayush1009208 ok.

@ayush1009208
Copy link
Author

@Anshgrover23 is the issue fixed in the website?

@Anshgrover23
Copy link
Collaborator

@ayush1009208 No, the dark mode is not enabled yet. kindly resolve conflicts and update your pr description add fixes #issue no

@Anshgrover23
Copy link
Collaborator

@ayush1009208 kindly, resolve the conflicts and tell me are you working on this.

1 similar comment
@Anshgrover23
Copy link
Collaborator

@ayush1009208 kindly, resolve the conflicts and tell me are you working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divanshu-go divanshu-go divanshu-go requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush1009208 @divanshu-go @Anshgrover23