Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve footer UI #196

Closed
wants to merge 10 commits into from
Closed

Conversation

Compilearner
Copy link
Contributor

Description

Improved the footer UI for better performance.

Fixes #(108)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so that they can be reproduced.

  • Test A
  • Test B

Screenshot (825)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Anshgrover23
Copy link
Collaborator

@Compilearner good work but few changes:

  • we have to scroll so see footer how will people know there is a footer
  • can u make like leave footer for now make a header for app, because it is necessary at this point.
2024-10-16.10-45-37.mp4

@Anshgrover23
Copy link
Collaborator

@Compilearner and kinldy update your branch.

@Compilearner
Copy link
Contributor Author

I will make the header for the project. But i think others are already working on this : #82 , #147

@Anshgrover23
Copy link
Collaborator

@Compilearner i think you can do this because this is open source and the issue and PR you tagged are doing work for more than 3+ days so i think this is more delayed if we wait for them you can continue your work.

@Anshgrover23
Copy link
Collaborator

@Compilearner also resolve conflicts.

@Compilearner
Copy link
Contributor Author

Compilearner commented Oct 19, 2024

So, No footer right??
If yes, I'll close this pull request.

@Anshgrover23
Copy link
Collaborator

@Compilearner yes please.

@Compilearner Compilearner deleted the improve-footer-ui branch October 19, 2024 15:24
@Compilearner Compilearner restored the improve-footer-ui branch October 19, 2024 15:24
@Compilearner Compilearner deleted the improve-footer-ui branch October 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants