Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Winter Drop (1.21.4) blocks #78

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add Winter Drop (1.21.4) blocks #78

wants to merge 11 commits into from

Conversation

stwalkerster
Copy link
Collaborator

I've been meaning to push this up for a while, but there's still an issue with the biome colouring not being quite correct for the Pale Garden biome. It's as close as I think I can get it without substantially more invasive changes though, and it's something that can be fixed later.

This table was hard-to-read and interpret due to its jagged form.

Change-Id: Ib3321c8f424486ba6bf01e7e097edec438b0de92
Change-Id: I644dc92a8915472a4a809bcce66014f94afe4533
Change-Id: I4985a006e06e381f1424e8b7d9acd8af81cba5c4
Change-Id: I746f7cdddd63b8de4a6b5eefbe1ac84941cb49a5
Change-Id: I7264e355902eb8cfcd51520eeeff7cc3204707dd
Change-Id: If4eb3b477876339f871648224738ccacfc7713d5
Change-Id: I173b4b63ccac34bd93893751998e50838b2a7985
Change-Id: I834e33d296c5af9a438740d1d5851bce1068ae91
Change-Id: Iedbea09eac4bde22a9f8976d5c7d296d869e150a
Change-Id: I14a62aa5e23239024a679495526c4f8f17fec57e
Change-Id: Ia32bc40c4e4f18bc5bbeb5dfca3195ee3ce66ecd
@Derjik
Copy link

Derjik commented Dec 27, 2024

Hello, great thanks for implementing the new biome !

I just tested it today, I'd suggest adding a color of your choice for the Biome Overlay in the default_biomes[] array of overlay-biomes.c : currently, Pale Gardens show no distinctive colouring (see screenshot below)
PaleGarden_BiomeOverlay

Edit : or maybe make it so that it maps just like other "Forest"-type biomes ?

Thanks again for your work, much appreciated o/

@stwalkerster
Copy link
Collaborator Author

stwalkerster commented Dec 27, 2024

I totally forgot about the biome overlay; thanks for pointing it out.

That said, there appears to be a substantial amount of oddness with the biome overlay. I can see cherry grove biomes have the same issue:
image

There's the ocean which is rendering without any overlay at all, despite having an overlay in the code:
image

Also mushroom fields (yes, biome overlay is enabled in this screenshot):
image

There's this sunflower plains biome which renders the same as the river surrounding it:
image

I think I'm going to look at the biome overlay more generally in a different PR. I suspect I'm not the first person to have forgotten about it, since the order in overlay-biomes.c is substantially different to the order in biomes.h. I think bodging in an overlay colour for just Pale Garden is going to require setting biome colours for a bunch of different biomes, and it'd be better for me to do it once and correctly (and hence, not in this PR - #79)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants