fix: getbounds from filter obj #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and @dadiorchen i haven't tested this on my local yet , how do i connect my local web-map-core to my local-web-map-client |
|
@Mohmn you can try to install the lib in this way: |
|
@Mohmn good try, I just am little worried about the messy model of the web map core, maybe we need to do a refactor and re-design the core in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inorder to fix (Greenstand/treetracker-web-map-client#754) get filter method has to return bounds as a key-pair value too,as we can see this code (https://github.com/Greenstand/treetracker-web-map-api/blob/a1e948b3abbff826196bb3dffcc4b93c00c7dde5/src/models/Map.js#L44) suggests that we need to pass bounds as query param too which we aren`t currently doing