-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter bookmark #1010
Draft
SuspenseFallback
wants to merge
33
commits into
Greenstand:master
Choose a base branch
from
SuspenseFallback:filter-bookmark
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Filter bookmark #1010
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
673d879
feat: initial filter test
SuspenseFallback fee2813
chore: fix merge error
SuspenseFallback fc286cb
fix: more merge errors
SuspenseFallback 6b990a2
fix: more merge errors
SuspenseFallback 9de70eb
fix: ear
SuspenseFallback 895e3cf
feat: working on payments filter
SuspenseFallback 5514d00
feat: filter persists on growers
SuspenseFallback 862e316
chore: draft pr
SuspenseFallback d9da245
fix: multiple errors in code after merge
SuspenseFallback 76c92d1
chore: revert import reordering to reduce merge complexity
nmcharlton a92442d
chore: revert import reordering to reduce merge complexity
nmcharlton 1db7230
refactor: consolidate duplicate handleQuerySearchParams implementations
nmcharlton aa97c72
fix: give handleQuerySearchParams access to current params
nmcharlton d5841d7
fix: add missing url var
nmcharlton 6d85531
feat: move searchParams handling to context components
nmcharlton 52e5394
feat: rework searchParams filter lifecycle
nmcharlton f13acd3
feat: add abort controllers to prevent duplicate queries
nmcharlton ad2da29
fix: provide default empty searchParams
nmcharlton 629f2c4
feat: make searchParams handling more robust
nmcharlton 7c01348
feat: omit default values from searchParams
nmcharlton c765dec
fix: typo
nmcharlton 13f2d87
chore: fix merge errors
nmcharlton ad0707c
chore: revert unnecessary merge changes
nmcharlton 11cbe86
fix: handle string and Date formats for date filter
nmcharlton 5444c7e
fix: handle string and Date format dates in filter
nmcharlton f82e895
fix: use correct name for filter.organization_id
nmcharlton 755dd78
chore: revert capture matching filter
nmcharlton 8b28f9a
chore: revert capture matching changes
nmcharlton 2ccf498
chore: revert capture matching changes
nmcharlton d571a6e
fix: support empty search string
nmcharlton a639650
chore: remove duplicate useEffect for captures
nmcharlton 73fcbea
refactor: declare `fromSearchParams` as static class method
nmcharlton 3946bba
Merge branch 'master' into filter-bookmark
nmcharlton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be inside a conditional like in the Verify and Grower contexts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the others that are incorrect.
I suspect the
if (searchParams)
check is an artefact of a previous way of doing this.We probably shouldn't check it as we're not using it within this
useEffect
. I'll do some more testing.