Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple encrypted values in Input configurations #21217

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

kingzacko1
Copy link
Contributor

Description

Remove return from for loop when iterating over input configuration values so that multiple EncryptedValue fields can be supported

Motivation and Context

The short-circuiting of this for-loop only allowed for one value in an input configuration to be an encrypted value. Any others would not be transformed and the input would fail to be saved to the DB.

How Has This Been Tested?

Local dev env

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kingzacko1
Copy link
Contributor Author

@thll this was preventing some development on a new input with multiple encrypted values going into the DB. Seems like this should be the fix, but just wanted to check with you that there wasn't a good reason for the return statement there.

Copy link
Contributor

@thll thll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the return statement looks out of place. Thanks for fixing!

@kingzacko1 kingzacko1 merged commit 3981080 into master Dec 20, 2024
6 checks passed
@kingzacko1 kingzacko1 deleted the fix-multiple-encrypted-input-config-values branch December 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants