Create ClipboardIconButton.
#21135
Merged
Create ClipboardIconButton.
#21135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
clipboard-icon-button
branch
from
13965d2 to
3d29f5e
Compare
linuspahl
force-pushed
the
clipboard-icon-button
branch
from
efe657f to
44034ef
Compare
linuspahl
force-pushed
the
clipboard-icon-button
branch
from
44034ef to
e69b9a2
Compare
dennisoelkers
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
In the past a
ClipboardButtonhas been created. Now we want to implement anIconButtonwhich copies the provided text on click.Example of icon buttons:
Since we can't reuse the
ClipboardButtonfor this I extracted the related logic into a wrapper component which can be used for the existingClipboardButtoncomponent and the newly createdClipboardIconButtoncomponent.Screenshot of
CopyIconButton:/nocl