Add selective plugin loading mechanism #21007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ks for fresh installation of the Graylog cluster
…sn't do the fresh installation detection any more
Co-authored-by: Bernd Ahlers <[email protected]>
Co-authored-by: Bernd Ahlers <[email protected]>
Co-authored-by: Bernd Ahlers <[email protected]>
Co-authored-by: Bernd Ahlers <[email protected]>
# Conflicts: # graylog2-server/src/main/java/org/graylog2/CommonNodeConfiguration.java # graylog2-server/src/main/java/org/graylog2/GraylogNodeConfiguration.java
# Conflicts: # graylog2-server/src/main/java/org/graylog2/CommonNodeConfiguration.java
…e all properties of PathConfiguration only for plugin loading
# Conflicts: # graylog2-server/src/main/java/org/graylog2/GraylogNodeConfiguration.java
# Conflicts: # data-node/src/main/java/org/graylog/datanode/Configuration.java # data-node/src/main/java/org/graylog/datanode/bindings/PreflightChecksBindings.java # data-node/src/main/java/org/graylog/datanode/bootstrap/preflight/OpensearchConfigSync.java # graylog2-server/src/main/java/org/graylog2/CommonNodeConfiguration.java # graylog2-server/src/main/java/org/graylog2/GraylogNodeConfiguration.java # graylog2-server/src/main/java/org/graylog2/bootstrap/CmdLineTool.java # graylog2-server/src/test/java/org/graylog2/commands/MinimalNodeCommandTest.java
moesterheld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a mechanism for loading plugins selectively.
This is needed to load different plugins for different node types (needed specifially for data node).
The selection is done by adding a
SpecificNodePluginannotation to the plugin class and specifying thePluginLoader.NodeTypeinGraylogNodeConfiguration.getPluginNodeType().To keep backward compatibility, the PluginLoader will load all plugins without the annotation if no type is provided (i.e. no type = Graylog), otherwise all plugins annotated with the given node type will be loaded.
/nocl
Motivation and Context
needed for selectively loading a trino node plugin in data node
How Has This Been Tested?
Tested with https://github.com/Graylog2/graylog-plugin-enterprise/pull/9214 and ensuring all Graylog plugins are loaded without the data node specific plugin. In data node, only the specified plugin is loaded.
Added unit test for filtering in PluginLoader.
Screenshots (if appropriate):
Types of changes
Checklist: