-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace font awesome with material symbol icons. #18208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
refactor/icons
branch
2 times, most recently
from
February 12, 2024 13:28
0a592b9
to
a3caac8
Compare
linuspahl
force-pushed
the
refactor/icons
branch
from
February 19, 2024 19:58
4985db7
to
4bccbf3
Compare
maxiadlovskii
approved these changes
Feb 23, 2024
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
With this PR we are replacing the icon library font-awesome with material symbols.
In general material symbols offer more icons, they are easier to customize, have a fixed width by default and they are all aligned in the same way.
We using material symbols as variable icon fonts, instead of implementing SVGs, because they are easier to implement and style.
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/6588
/nocl