extend cat api to get shards information for a specific index #18189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpfz0r
reviewed
Feb 13, 2024
mpfz0r
reviewed
Feb 13, 2024
graylog2-server/src/main/java/org/graylog2/indexer/indices/ShardsInfo.java
Outdated
Show resolved
Hide resolved
mpfz0r
reviewed
Feb 13, 2024
graylog2-server/src/main/java/org/graylog2/indexer/indices/ShardsInfo.java
Outdated
Show resolved
Hide resolved
kodjo-anipah
commented
Feb 14, 2024
graylog2-server/src/test/java/org/graylog2/indexer/cluster/ClusterIT.java
Outdated
Show resolved
Hide resolved
mpfz0r
reviewed
Feb 15, 2024
| int shard =jsonNode.get("shard").asInt(); | ||
|
|
||
| String ipString = getValueOrDefault(jsonNode, "ip", JsonNode::asText, null); | ||
| InetAddress ip = ipString != null ? InetAddress.getByName(ipString) : null; |
There was a problem hiding this comment.
I wonder if that's worth the complexity of having to handle UnknownHostException.
Couldn't we just return the string and let the consumer deal with potentially converting it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the internal cat api to return shards information for a specific index
part of https://github.com/Graylog2/graylog-plugin-enterprise/issues/6510
part of https://github.com/Graylog2/graylog-plugin-enterprise/issues/6273
/nocl