Handle Stream reference dependencies for entity sharing #17891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danotorrey
approved these changes
Jan 11, 2024
ryan-carroll-graylog
deleted the
17882-sharing-a-stream-scoped-entity-fails-with-error
branch
ryan-carroll-graylog
added a commit
that referenced
this pull request
Jan 12, 2024
* Add `stream_title` type to GRNRegistry * Replace stream_title dependencies with the acutal stream * Add unit test * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new
stream_titleEntity type was added in #17089 to allow creating Content Packs that reference Streams by title instead of ID.The Entity sharing code uses the Content Pack dependency resolution code to warn users if they are sharing an entity that has dependencies that should also be shared. This was causing errors due to
stream_titlebeing an unrecognized GRN type.Since we really want the actual Stream dependency in this context anyway, this update maps
STREAM_REF_V1dependencies to theirSTREAM_V1ModelTypes in the share dependency resolver.Motivation and Context
Closes: #17882
How Has This Been Tested?
Locally in development environment, sharing stream scoped entities.
Screenshots (if appropriate):
Types of changes
Checklist: