(Backport 5.2) - Use Stream Names for Content Packs #17609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use stream names for content packs * Cleanup * Fix install * cleanup * remove unused import * Handle multiple streams better, minor name refactoring * Add handling for the rest of the entity types that reference streams * Fix line spacing * Add missing license header * Fix failing tests * Add changelog entry * Return StreamReference Entity Exerpts to front end to ensure proper handling of existing entities * Use Stream title to generate excerpt IDs to avoid collision with regular Streams. Irrellevant to content packs but was causing problems for start page and related tests. * Add default naive implementation of StreamService loadAllByTitle() * Resolve stream deps for dashboard widgets
danotorrey
approved these changes
Dec 8, 2023
kingzacko1
approved these changes
Dec 8, 2023
ryan-carroll-graylog
deleted the
backport-5.2/16885-update-content-pack-system-to-handle-streams-by-name-rather-than-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17089 to 5.2.