Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field type list pagination with querying and filtering. #17290

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

luk-kaminski
Copy link
Contributor

@luk-kaminski luk-kaminski commented Nov 14, 2023

Description

Field type list pagination with querying and filtering.
Support for querying and filtering on Entity Table even if it is not used for Mongo-backed entity, but rather for in-memory object.

/nocl

Motivation and Context

Required for Field Type Management page.

How Has This Been Tested?

Manually and with new unit tests.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@luk-kaminski luk-kaminski changed the title Initial, beta version of field type list pagination with querying and… Field type list pagination with querying and filtering. Nov 15, 2023
@luk-kaminski luk-kaminski force-pushed the feature/field_type_list_filtering branch from fcbfd7c to d576ba1 Compare November 15, 2023 10:04
@luk-kaminski luk-kaminski marked this pull request as ready for review November 15, 2023 13:06
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luk-kaminski luk-kaminski merged commit da26f9f into master Nov 15, 2023
4 checks passed
@luk-kaminski luk-kaminski deleted the feature/field_type_list_filtering branch November 15, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants