Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/5.2 17204 rules editor tooltip #17223

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

zeeklop
Copy link
Contributor

@zeeklop zeeklop commented Nov 8, 2023

Replaces hard-coded colors for values defined on the theme.

Description

The tooltip shown when the rule has an error had white letters on white background. In this particular component these values where set without using the theme. This PR changes the hard-coded values for those on the theme to keep a more consistent UI across the application.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@zeeklop zeeklop requested a review from a team November 8, 2023 16:55
@zeeklop zeeklop self-assigned this Nov 8, 2023
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests successfully on 5.2!

@zeeklop zeeklop merged commit 14b16e9 into 5.2 Nov 8, 2023
2 checks passed
@zeeklop zeeklop deleted the fix/5.2-17204-rules-editor-tooltip branch November 8, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants