-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Stats are disabled by default" color on IndexSet page #17201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it LGTM. (theme spacing nitpick not a blocker though)
@@ -35,6 +35,37 @@ import useSendTelemetry from 'logic/telemetry/useSendTelemetry'; | |||
import useLocation from 'routing/useLocation'; | |||
import { TELEMETRY_EVENT_TYPE } from 'logic/telemetry/Constants'; | |||
|
|||
const Toolbar = styled(Row)(({ theme }) => css` | |||
border-bottom: 1px solid ${theme.colors.gray[90]}; | |||
padding-bottom: 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to replace the value with theme spacing?
const GlobalStatsCol = styled(Col)` | ||
display: flex; | ||
align-items: center; | ||
gap: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too?
These changes fix the issue of "Stats are disabled by default" not being visible because of the text color.
fix #16899
/nocl
Types of changes
Checklist: