Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Stats are disabled by default" color on IndexSet page #17201

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented Nov 7, 2023

These changes fix the issue of "Stats are disabled by default" not being visible because of the text color.

fix #16899
/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it LGTM. (theme spacing nitpick not a blocker though)

@@ -35,6 +35,37 @@ import useSendTelemetry from 'logic/telemetry/useSendTelemetry';
import useLocation from 'routing/useLocation';
import { TELEMETRY_EVENT_TYPE } from 'logic/telemetry/Constants';

const Toolbar = styled(Row)(({ theme }) => css`
border-bottom: 1px solid ${theme.colors.gray[90]};
padding-bottom: 15px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to replace the value with theme spacing?

const GlobalStatsCol = styled(Col)`
display: flex;
align-items: center;
gap: 10px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too?

@ousmaneo ousmaneo requested a review from gally47 November 9, 2023 13:13
@ousmaneo ousmaneo merged commit 5faef59 into master Nov 15, 2023
4 checks passed
@ousmaneo ousmaneo deleted the issue-16899 branch November 15, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Stats are disabled by default" not visible
2 participants