Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move existing DataNode config into separate page #17104

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Move existing DataNode config into separate page #17104

merged 6 commits into from
Nov 7, 2023

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Oct 27, 2023

Motivation and Context

#17085

Screenshots (if appropriate):

Screenshot 2023-10-27 at 17 15 01

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Oct 27, 2023
@gally47 gally47 requested review from grotlue and ousmaneo October 30, 2023 09:40
ousmaneo
ousmaneo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@grotlue grotlue merged commit 1440abc into master Nov 7, 2023
2 checks passed
@grotlue grotlue deleted the datanode-page branch November 7, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousmaneo ousmaneo ousmaneo approved these changes

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@gally47 gally47

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gally47 @ousmaneo @grotlue