Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify auto-refresh behaviour by disabling auto-refresh on search bar form changes #16893

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

linuspahl
Copy link
Contributor

Description

Motivation and Context

As described in https://github.com/Graylog2/graylog-plugin-enterprise/issues/5896 the behaviour of the search auto-refresh can be confusing.

  1. When you make a change, do not submit the form and start the auto-refresh, the search does not contain the latest change.
  2. When you make a change while the auto-refresh is active, the search does not contain the latest change

With this PR we are now:

  • In case 1 submitting the change when starting the auto-refresh
  • in case 2 stoping the auto-refresh, when making changes while it is active. This way the behaviour is unified with similar cases. We also tested submitting the changes in this case, but always ran into issues with this approach.

Fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/5896

@linuspahl linuspahl force-pushed the issue-enterprise-5896/auto-refresh branch from c7e396d to f6691d6 Compare October 16, 2023 07:48
@dennisoelkers dennisoelkers merged commit 164f36b into master Oct 16, 2023
1 of 2 checks passed
@dennisoelkers dennisoelkers deleted the issue-enterprise-5896/auto-refresh branch October 16, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants