Add search result statistics on the main search screen #16130
Conversation
maxiadlovskii
changed the title
| const ExecutionInfo = () => { | ||
| const result = useAppSelector(selectCurrentQueryResults); | ||
| const total = result?.searchTypes && Object.values(result?.searchTypes)?.[0]?.total; | ||
|
|
There was a problem hiding this comment.
Currently we show "Query executed in 0ms" + "Total results: 0" when executing search for the first time.
Maybe let's unify it with the sidebar, where we show <i>No query executed yet.</i> in this case?
|
|
||
| return ( | ||
| <OverlayDropdown show={open} | ||
| toggleChild={<QueryHelpButton bsStyle="link"><Icon name="question-circle" /></QueryHelpButton>} |
There was a problem hiding this comment.
It would be nice to use a button with a smaller height here, so the widget content receives more space.
Before
After:
There was a problem hiding this comment.
I can imagine something like this
It could work well in combination with making the time range (5 minutes ago) + the icon the trigger to open the popover.
There was a problem hiding this comment.
i also like to display the icon the gray we use for the widget actions, to put the focus on the widget content.
|
|
||
| return ( | ||
| <i> | ||
| Query executed in {' '} |
There was a problem hiding this comment.
The reads like we want to display two spaces at the end of the line.
| } | ||
| const HelpPopover = ({ widgetExecutionData }: { widgetExecutionData: WidgetExecutionData}) => ( | ||
| <PopoverContainer> | ||
| <p><strong>Execution Info</strong></p> |
There was a problem hiding this comment.
You can also just use the popover title prop, this way we unify the styling.
There was a problem hiding this comment.
It would also be nice to remove the bottom margin:
There was a problem hiding this comment.
It looks like we just need to remove the table bottom margin
There was a problem hiding this comment.
Regarding the dashboard widget popover toggle, it would be nice to move it 5 or even 10 pixel to the left so it wont be overlapped by the widget resize handle:
In addition we can use the same gray here, like the one we use for the widget action icons.
Maybe let's get rid of the table background color?
linuspahl
deleted the
fix/Total-result-count-missing-from-query-page/issue-7386
branch
|
💯 I love it! |
Description
Pr adds
total results value to the sidebar execution info
Search result statistics to search screen
Execution info popover to each dashboard widget
Motivation and Context
fix: Total result count missing from query page#7386
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
/jenkins-pr-deps https://github.com/Graylog2/graylog-plugin-enterprise/pull/6564