Lazy configuration processing, printing all errors at once (#19801)

* Lazy configuration processing, printing all errors at once * Added changelog
Graylog2 · Jul 2, 2024 · 33dfb06 · 33dfb06
1 parent 843a083
commit 33dfb06
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelog/unreleased/issue-19207.toml b/changelog/unreleased/issue-19207.toml
@@ -0,0 +1,5 @@
+type="c"
+message="Lazy configuration processing for datanode, collecting all errors in one go."
+
+issues=["19207"]
+pulls=["19801"]
diff --git a/data-node/src/main/java/org/graylog/datanode/bootstrap/CmdLineTool.java b/data-node/src/main/java/org/graylog/datanode/bootstrap/CmdLineTool.java
@@ -269,8 +269,6 @@ public void doRun(Level logLevel) {
 
         coreConfigInjector = setupCoreConfigInjector();
 
-        processConfiguration(jadConfig);
-
         if (isDumpConfig()) {
             dumpCurrentConfigAndExit();
         }
@@ -421,7 +419,7 @@ private void installConfigRepositories() {
 
     protected void processConfiguration(JadConfig jadConfig) {
         try {
-            jadConfig.process();
+            jadConfig.processFailingLazily();
         } catch (RepositoryException e) {
             LOG.error("Couldn't load configuration: {}", e.getMessage());
             System.exit(1);