Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sort icon to CollectorsList #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxiadlovskii
Copy link

@maxiadlovskii maxiadlovskii commented Nov 18, 2022

Please note, this PR is based on Graylog2/graylog2-server#13987 which needs to be merged first.

Description

This PR changes the Sort Icon to have the same view in all application

Motivation and Context

for more details take a look at Graylog2/graylog2-server#13982

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Notes for Reviewers

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
  • Sync up with the author before merging

/jenkins-pr-deps Graylog2/graylog2-server#13987

Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

{this._getSortingIcon('node_id')}
</SortableTh>
<SortableTh onClick={this.sortByCollectorStatus}>
{this._getSortingIcon('node_id', this.sortByNodeId)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use an actual component here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants