add hide grades feature with --hide_grades flag #155

ericshermancs · 2019-05-28T23:37:14Z

No description provided.

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -391,6 +393,8 @@ def main():
            "Enter password: ") if not args.password else args.password
        number = input(
            "Enter phone number: ") if not args.phone else args.phone
+        school = input(
+            "Enter college code: ").upper() if not args.school else args.school.upper()


line too long (87 > 79 characters)

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -274,7 +275,7 @@ def refresh(remaining_attempts=2):
        else:
            refresh(remaining_attempts - 1)

-def start_notifier(is_welcome=False):
+def start_notifier(is_welcome=False, hide_grades=False):


expected 2 blank lines, found 1

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -194,10 +195,10 @@ def sign_in(remaining_attempts=5):
    else:
        return False

-def create_instance():
+def create_instance(hide_grades=False):


expected 2 blank lines, found 1

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -178,7 +178,8 @@ def welcome_message():
        .newline() \
        .add("Your UID is: {0}".format(custom_hash(user.get_username()))) \
        .newline() \
-        .add("You're all set up. You should see your current grades below!") \
+        .add("You're all set up. You should see your current grades below!"\
+        if not hide_grades else "") \


continuation line under-indented for visual indent

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -178,7 +178,8 @@ def welcome_message():
        .newline() \
        .add("Your UID is: {0}".format(custom_hash(user.get_username()))) \
        .newline() \
-        .add("You're all set up. You should see your current grades below!") \
+        .add("You're all set up. You should see your current grades below!"\


the backslash is redundant between brackets

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -169,7 +169,7 @@ def find_changes(old, new):

 ###********* Main Program *********###

-def welcome_message():
+def welcome_message(hide_grades=False):


expected 2 blank lines, found 1

hound · 2019-05-28T23:37:17Z

src/core/grade_notifier.py

@@ -83,18 +83,18 @@ def send_text(message, sendNumber):
    Converts a changelog array to a message
    Changelog: The list of classes which have had grade changes
 '''
-def create_text_message(change_log, is_welcome=False):
+def create_text_message(change_log, is_welcome=False, hide_grades=False):


expected 2 blank lines, found 0

CUNY-Bot · 2019-05-28T23:38:25Z

	2 Errors
🚫	Please provide a summary in the Pull Request description
🚫	Oh No! You failed a unit test Run Python3 ./src/tests/tests.py to see which test failed ..E/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py:643: ResourceWarning: unclosed <ssl.SSLSocket fd=5, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=(‘10.100.2.202’, 49290), raddr=(‘128.228.24.52’, 443)> outcome.errors.clear() ………. ====================================================================== ERROR: test_is_logged_in (main.TestAPIIntegration) ———————————————————————- Traceback (most recent call last): File “./src/tests/tests.py”, line 233, in test_is_logged_in api.login() File “/usr/local/lib/python3.7/site-packages/cunyfirstapi/cunyfirstapi.py”, line 59, in login self._password, File “/usr/local/lib/python3.7/site-packages/cunyfirstapi/login.py”, line 66, in login encreply = tree.xpath(‘//*[@name=”enc_post_data”]/@value’)[0] IndexError: list index out of range Ran 13 tests in 1.652s FAILED (errors=1)

	1 Warning
⚠️	257 PEP 8 issues found

	1 Message
📖	Thanks for remembering to add a test!

Generated by 🚫 Danger

Huddie · 2019-05-31T05:27:15Z

Hey looks cool but a few changes

Flags should be passed always with either a true or false value.

—hides_grades=“true” for example

hides_grades should not be passed into welcome_message. It should be a set global variable. Maybe even create a sessionConfig object that holds config for the session.

hound · 2019-06-05T14:21:23Z

src/core/grade_notifier.py

@@ -275,6 +278,7 @@ def refresh(remaining_attempts=2):
            refresh(remaining_attempts - 1)

 def start_notifier(is_welcome=False):
+    #global hide_grades


block comment should start with '# '

Huddie

Looks good

Huddie · 2019-07-01T01:07:30Z

what just happened. why are so may files changed all of a sudden
what did you just change?

add hide grades feature with --hide_grades flag

b319f5f

hound bot reviewed May 28, 2019

View reviewed changes

ericshermancs added 2 commits May 28, 2019 23:08

Update index.php

ba32d55

Update index.php

3385f3e

ericshermancs added 2 commits June 5, 2019 10:18

fix how hide grades works in code and in php

5c7894c

fix how hide grades works in code and in php

a1484ae

hound bot reviewed Jun 5, 2019

View reviewed changes

Huddie approved these changes Jun 30, 2019

View reviewed changes

ericshermancs added 2 commits June 30, 2019 19:50

idk why its asking me to commit its the same thing

7214a3a

idk why its asking me to commit its the same thing

78ef3e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add hide grades feature with --hide_grades flag #155

add hide grades feature with --hide_grades flag #155

ericshermancs commented May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

hound bot May 28, 2019

CUNY-Bot commented May 28, 2019 •

edited

Loading

Huddie commented May 31, 2019

hound bot Jun 5, 2019

Huddie left a comment

Huddie commented Jul 1, 2019

add hide grades feature with --hide_grades flag #155

Are you sure you want to change the base?

add hide grades feature with --hide_grades flag #155

Conversation

ericshermancs commented May 28, 2019

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

hound bot May 28, 2019

Choose a reason for hiding this comment

CUNY-Bot commented May 28, 2019 • edited Loading

Huddie commented May 31, 2019

hound bot Jun 5, 2019

Choose a reason for hiding this comment

Huddie left a comment

Choose a reason for hiding this comment

Huddie commented Jul 1, 2019

CUNY-Bot commented May 28, 2019 •

edited

Loading