Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for config injection from other modules #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added support for config injection from other modules #174

wants to merge 2 commits into from

Conversation

AndreKlang
Copy link

Fixes #173

@riconeitzel
Copy link

@GordonLesti hier kannst du auch drauf drücken.

@sprankhub
Copy link
Contributor

I think this would be a great addition @GordonLesti

@ProxiBlue
Copy link

Not needing to generate setup scripts to adjust config admin, taking care not to override some other modules injected config....will simply be awesome. This has been sitting for 10 months about now. Any help needed? Whats the hurdle to get this merged? Glad to give some time to help get this merged.

@GordonLesti
Copy link
Owner

Fine, I may have underestimated the benefit for module developers. I will merge it as soon as possible. @AndreKlang I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreKlang @riconeitzel @sprankhub @ProxiBlue @GordonLesti