Handle StandalonePods
Succeeded
case when checking status
#9580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Skaffold checks a standalone pod's status (method
checkStandalonePodsStatus
) , it currently only considersFailed
andRunning
state, any other status will lead the pod to be systematically added to thependingPods
collection.According to the documentation, a pod can be in 5 different states:
Pending
,Running
,Succeeded
,Failed
orUnknown
.While it make sense for
Pending
orUnknown
pods to be added to thependingPods
collection, I think it does not for theSucceeded
ones (pods that terminated successfully)This PR introduces a tiny change which just skips
Succeeded
pods.Tests
I tried to look at other test and could only find:
CheckStatus
that don't involveStandalonePods
resourceTestPollServiceStatus
,TestPollJobStatus
,TestPollDeployment
, none of which involveStandalonePods
resourcePlease let me know if I've missed it, I'd be happy to add test on it.
Thanks!