Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oci layout path fix #3364

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

EladAviczer
Copy link

@EladAviczer EladAviczer commented Nov 20, 2024

Fixes #2455
Description
This PR addresses issue #2455 by enhancing the functionality of the --oci-layout-path flag in kaniko. Previously, this flag only accepted absolute paths, which limited usability for users working with relative paths.
(unittests not included since i use the same tests for all other opts)
Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed. (not needed)

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds relative path usage for --oci-layout-path 

Copy link

google-cla bot commented Nov 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--oci-layout-path requires an absolute path
1 participant