Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow pushing images with different arch/os to docker daemon #4268

Merged
merged 45 commits into from
Jun 25, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jun 6, 2024

Fixes #4265

@mpeddada1 mpeddada1 marked this pull request as ready for review June 7, 2024 14:46
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Jun 10, 2024

Notes on kokoro-ubuntu timeout:

  • The job passed on f2d886b but started failing after test for arm64 was added.

Unable to reproduce locally with ./gradlew clean build :jib-core:integrationTest.

kokoro-macos:

  • The job is failing during job start up:
++ docker-machine ls
NAME   ACTIVE   DRIVER   STATE   URL   SWARM   DOCKER   ERRORS
++ docker-machine start default
Docker machine "default" does not exist. Use "docker-machine ls" to list machines. Use "docker-machine create" to add a new one.

@mpeddada1 mpeddada1 closed this Jun 11, 2024
@mpeddada1 mpeddada1 reopened this Jun 11, 2024
@mpeddada1 mpeddada1 requested a review from blakeli0 June 21, 2024 12:55
@mpeddada1
Copy link
Contributor Author

[Update on CI] Splitting the test methods up into separate test classes no longer causes the builds to be stuck. Ready for another round of review.

@mpeddada1 mpeddada1 merged commit ff15988 into master Jun 25, 2024
11 checks passed
@mpeddada1 mpeddada1 deleted the avoid-throwing-exception branch June 25, 2024 15:36
@geoand
Copy link

geoand commented Jun 26, 2024

Thanks for the fix folks!

As we are seeing someone reporting something similar in Quarkus, would it be possible to know an approximate timeline for a release of jib-core that will contain the fix?
Thanks!

@calebAtIspot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to build amd-64 docker on Mac M3 machine
6 participants