chore: Dynamically create test jars for JarCommandTest #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
reviewed
Mar 13, 2024
jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
Outdated
Show resolved
Hide resolved
jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
352
to
354
| JavaCompiler.CompilationTask task = compiler.getTask(null, fileManager, null, options, null, compilationUnits); | ||
| boolean success = task.call(); | ||
| assertThat(success).isTrue(); |
There was a problem hiding this comment.
How about we use an if-else statement that proceeds with the jar building stage below if task.call() is true otherwise logs an error message if the compilation fails?
There was a problem hiding this comment.
If we just silently log the message, then we might not notice the failure.
There was a problem hiding this comment.
Ah sorry, good point!
[Optional] Alternatively, to have a clear separation between the "arrange", "act" and "assert" blocks in our tests - consider using Preconditions.checkState(task.call(), "<error message>");.
jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
Outdated
Show resolved
Hide resolved
|
Thanks for addressing this @meltsufin! Running |
mpeddada1
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4205.