Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaut base image for Java 21 #4144

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

rquinio
Copy link
Contributor

@rquinio rquinio commented Nov 19, 2023

I looked at all occurrences of "eclipse-temurin", I don't think I missed other places to update.

Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.

Before filing a pull request, make sure to do the following:

This helps to reduce the chance of having a pull request rejected.

Fixes #4137 🛠️

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.8% 93.8% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@MouradHM
Copy link

MouradHM commented Feb 6, 2024

Ola ! Any news on that PR ?

@patrickwilmes
Copy link

Would be awesome to have the changes available. Any chance that this will be available before the java 22 release?

Copy link
Contributor

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@mpeddada1 WDYT?

@meltsufin meltsufin requested a review from mpeddada1 March 19, 2024 01:13
@meltsufin meltsufin merged commit 1488874 into GoogleContainerTools:master Mar 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically select correct base image for Java 21
8 participants