Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved : NPE if the server doesn't provide any HTTP content for an error #2542

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Solved : NPE if the server doesn't provide any HTTP content for an error #2542

merged 7 commits into from
Jun 29, 2020

Conversation

louismurerwa
Copy link
Contributor

Fixes #2532

@chanseokoh
Copy link
Member

@louismurerwa will fix style errors and re-push.

@chanseokoh
Copy link
Member

@louismurerwa there have been an external breaking change in our test environment recently (#2537). Your PR branch had been branched out before #2537 was fixed. Merge with the latest master HEAD to fix the test failure and push the up-to-date branch again.

chanseokoh
chanseokoh reviewed Jun 29, 2020
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, basically.

jib-core/src/main/java/com/google/cloud/tools/jib/registry/RegistryEndpointCaller.java Outdated Show resolved Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/registry/RegistryEndpointCaller.java Outdated Show resolved Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/registry/RegistryEndpointCallerTest.java Outdated Show resolved Hide resolved
@louismurerwa louismurerwa merged commit aee0626 into master Jun 29, 2020
@louismurerwa louismurerwa deleted the louis-fixnpeexception branch June 29, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

@loosebazooka loosebazooka Awaiting requested review from loosebazooka

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE if the server doesn't provide any HTTP content for an error
3 participants
@louismurerwa @chanseokoh @googlebot