feat(Storage): Update samples to showcase Storage Autoclass V2 usage #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: storage
vishwarajanand
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Will re-review this after the library pr: googleapis/google-cloud-php#6731
Co-authored-by: Vishwaraj Anand <[email protected]>
vishwarajanand
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Tests are passing because autoclass terminalStorageClass param is added in RequestBuillder.php#L134. Since the feature is GA now, this can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go/ac2-1-sdk-request for more details.
Fixes #1919