Address pipe-read race condition #1834

jefferbrecht · 2024-11-21T19:59:09Z

Description

cmd.Wait() must not be called before reading completes; it was previously being called too early.

Tests passed locally

Unit tests
- Unit tests do not apply.
- Unit tests have been added/modified and passed for this PR.
Integration tests
- Integration tests do not apply.
- Integration tests have been added/modified and passed for this PR.
Documentation
- This PR introduces no user visible changes.
- This PR introduces user visible changes and the corresponding documentation change has been made.
Minor version bump
- This PR introduces no new features.
- This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
- This PR bumps the version.

cmd.Wait() must not be called before reading completes; it was previously being called too early.

jefferbrecht force-pushed the jefferbrecht-transformtests branch from 801db3a to 6a0d81b Compare November 21, 2024 21:37

jefferbrecht changed the title ~~Handle process termination race~~ Address pipe-read race condition Nov 21, 2024

Address pipe-read race condition

0536c9a

cmd.Wait() must not be called before reading completes; it was previously being called too early.

jefferbrecht force-pushed the jefferbrecht-transformtests branch from 6a0d81b to 0536c9a Compare November 26, 2024 20:14

quentinmit approved these changes Nov 26, 2024

View reviewed changes

jefferbrecht merged commit 1a21b8f into master Nov 27, 2024
66 of 69 checks passed

jefferbrecht deleted the jefferbrecht-transformtests branch November 27, 2024 15:13