healthchecks : Improve self logs processing and healthchecks logs. #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscovalentecastro
force-pushed
the
fcovalente-remove-debug-logs
branch
from
38458ca to
29dd983
Compare
franciscovalentecastro
changed the title
franciscovalentecastro
force-pushed
the
fcovalente-remove-debug-logs
branch
4 times, most recently
from
993c83f to
8ffda40
Compare
franciscovalentecastro
requested review from
a team and
XuechunHou
and removed request for
a team
internal/healthchecks/error.go
Outdated
| Message: "Ops Agent failed to parse logs", | ||
| Action: "Refer to provided documentation link.", | ||
| ResourceLink: "https://cloud.google.com/stackdriver/docs/solutions/agents/ops-agent/troubleshoot-find-info", | ||
| IsFatal: true, |
There was a problem hiding this comment.
Is this actually a fatal error? Won't fluent-bit continue to run if it fails to parse a log?
There was a problem hiding this comment.
It is not a fatal error. Thanks for mentioning. I changed to IsFatal: false.
confgenerator/self_logs.go
Outdated
| @@ -182,13 +172,7 @@ func generateSelfLogsSamplingComponents(ctx context.Context) []fluentbit.Compone | |||
| // This method creates a component that enforces the `Structured Health Logs` format to | |||
| // all `ops-agent-health` logs. It sets `agentKind`, `agentVersion` and `schemaVersion`. | |||
| // It also translates `code` to the rich text message from the `selfLogTranslationList`. | |||
There was a problem hiding this comment.
Remove this comment line if it's no longer needed
There was a problem hiding this comment.
I removed the // It also translates "code" to the rich text message from the "selfLogTranslationList" part of the comment which is not relevant anymore.
Co-authored-by: Jeff Erbrecht <[email protected]>
franciscovalentecastro
force-pushed
the
fcovalente-remove-debug-logs
branch
from
af7aaa6 to
113e038
Compare
XuechunHou
approved these changes
Apr 19, 2024
jefferbrecht
approved these changes
Apr 22, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds several features and fixes that improve the runtime checks and self logs processing. Here is a detailed description :
severity: debuglogs (add self logs debug severity grep filter #1437, b/272779619).TestNoFluentBitDebugSelfLogs.self_logs.goimplementation after fluent-bit 2.2 upgrade bug fixes. (b/328463822).sourceLocationfield fromhealth-checks.logwhich doesn't bring enough value and makes it harder to read.Runtime Checkerrors intohealthchecks/error.go.Before
health-checks.logentryAfter
health-checks.logentryNote : This link points to the committed
.gofiles without the goldens to make it easier for review.Related issue
b/272779619, b/303073892, b/328463822
How has this been tested?
Checklist: