Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add missing t.Parallel to speed up tests #1627

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

martijnvans
Copy link
Contributor

Description

Corey noticed tests were slow, and after some digging I found:

--- PASS: TestPartialSuccess (3231.11s)
    --- PASS: TestPartialSuccess/windows-2016-core (441.91s)
    --- PASS: TestPartialSuccess/sql-std-2019-win-2019 (488.53s)
    --- PASS: TestPartialSuccess/windows-2022 (494.28s)
    --- PASS: TestPartialSuccess/windows-2016 (532.98s)
    --- PASS: TestPartialSuccess/windows-2019 (455.43s)
    --- PASS: TestPartialSuccess/windows-2019-core (412.52s)
    --- PASS: TestPartialSuccess/windows-2022-core (405.47s)

This normally looks different (a tiny number after the test name, TestPartialSuccess in this case) and indicates that the tests were running in series, not in parallel. Easy fix.

Related issue

None

How has this been tested?

automated tests should be enough.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@martijnvans martijnvans changed the title Add missing t.Parallel to speed up tests Testing: Add missing t.Parallel to speed up tests Feb 21, 2024
Copy link
Contributor

@franciscovalentecastro franciscovalentecastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I missed this from my fluent-bit upgrade PR (#1559). Thanks for adding it 🙏 !

@martijnvans martijnvans merged commit f3a372c into master Feb 21, 2024
66 of 69 checks passed
@martijnvans martijnvans deleted the martijnvans-add-missing-parallel branch February 21, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants