Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org_policy_policy documentation to make resource definition clearer #12445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juliorenner
Copy link

@juliorenner juliorenner commented Nov 27, 2024

This PR:

  • Updates the documentation to make it explicit that what is required for the resource definition is the project id, not the project name.

The project name may differ from the project id in google. For example, you may have a project ID sandbox-123123 while the project name is sandbox. If in this case using the project name the role creation will fail.

Release Note Template for Downstream PRs

See Write release notes for guidance.

updated org_policy_policy examples to use project_id instead of project name

Copy link

google-cla bot commented Nov 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot requested a review from trodge November 27, 2024 14:33
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Nov 27, 2024
@juliorenner
Copy link
Author

cla signed, not sure how to re-run it

@trodge
Copy link
Contributor

trodge commented Nov 27, 2024

/gcbrun

@juliorenner
Copy link
Author

@trodge anything missing to be able to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants