Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote BackupDR Backup and Data Source to GA #12435

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Matt-Ng
Copy link
Contributor

@Matt-Ng Matt-Ng commented Nov 26, 2024

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

backupdr: promoted datasource`google_backup_dr_data_source` to ga.
backupdr: promoted datasource`google_backup_dr_backup` to ga.

@Matt-Ng Matt-Ng changed the title Promote to GA Promote BackupDR Backup and Data Source to GA Nov 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 897 insertions(+))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@Matt-Ng Matt-Ng marked this pull request as ready for review November 26, 2024 17:44
@github-actions github-actions bot requested a review from BBBmau November 26, 2024 17:44
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

{{- end }}
"google_backup_dr_backup": backupdr.DataSourceGoogleCloudBackupDRBackup(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two data sources don't seem to contain any documentation. This comes from attempting to view it in the google-beta registry. Can you go ahead and include this as part of the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants