-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client full example to use basename of kms config #12418
base: main
Are you sure you want to change the base?
Fix client full example to use basename of kms config #12418
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
I don't believe this code is actually used anywhere. The generation produced no diff. I believe the file you intended to change is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
8a51e36
to
2c2c13d
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 12 Click here to see the affected service packages
🟢 All tests passed! View the build log |
@ScottSuarez I have done the changes. PTAL |
Add basename function usage in the integrations client full example to reflect correct usage. This would fix the errors due to recent api changes.
Release Note Template for Downstream PRs (will be copied)
Fixes: hashicorp/terraform-provider-google#20385