Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client full example to use basename of kms config #12418

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohitjangid
Copy link
Contributor

@rohitjangid rohitjangid commented Nov 25, 2024

Add basename function usage in the integrations client full example to reflect correct usage. This would fix the errors due to recent api changes.

Release Note Template for Downstream PRs (will be copied)

integrations: fixed example in docs to reflect usage of basename instead of full name in `cloud_kms_config` 

Fixes: hashicorp/terraform-provider-google#20385

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
Copy link
Contributor

I don't believe this code is actually used anywhere. The generation produced no diff. I believe the file you intended to change is integrations_client_full.tf.tmpl

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • integrations

🟢 All tests passed!

View the build log

@rohitjangid
Copy link
Contributor Author

see comment

@ScottSuarez I have done the changes. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Setting up Application Integration with Terraform
3 participants