Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApigeeEnvironment update response type. #12415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

masich
Copy link
Contributor

@masich masich commented Nov 22, 2024

This PR fixes the ApigeeEnvironment update response type according to the public documentation.

The issue is related to the fact that after requesting the update to ApigeeEnvironment here, the provider expects that the response will contain the Operation details to then wait for the Operation to complete here. Unlike Environment create request, which returns Operation, the update response has a type Environment according to the public docs, meaning that the ApigeeOperationWaitTime tries to process the Environment as Operation.

The Operation has a name key that is used to track its progress. However, the Environment also has a name key that contains the name of the Environment. That's why the users may see a weird apigee.googleapis.com/v1/<env-name>?alt=json GET requests that result in 404 Not Found while doing an update to their environments. In that case, the ApigeeOperationWaitTime interprets <env-name> as the operation name.

Here's a fix to a similar issue for the ApigeeOrganization: #12413

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

apigee: fixed error 404 for `environment` update requests.

@github-actions github-actions bot requested a review from BBBmau November 22, 2024 22:48
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 7 deletions(-))
google-beta provider: Diff ( 1 file changed, 7 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 51
Passed tests: 17
Skipped tests: 34
Affected tests: 0

Click here to see the affected service packages
  • apigee

🟢 All tests passed!

View the build log

Copy link

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants