Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify providing additional_networks for Slurm nodesets #3303

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Nov 24, 2024

Simplify definition of additional_networks, before the change one had to write for example

           additional_networks:
             - network: ""
               subnetwork: $(network2.subnetwork_self_link)
               subnetwork_project: ""
               network_ip: ""
               nic_type: VIRTIO_NET
               stack_type: ""
               queue_count: null
               access_config: []
               ipv6_access_config: []
               alias_ip_range: []

Now its possible to write just:

          additional_networks:
            - subnetwork: $(network2.subnetwork_self_link)
              nic_type: VIRTIO_NET

@wiktorn wiktorn changed the title Make most of the variables optional on additional networks to reduce … Simplify providing additional_networks for Slurm nodesets Nov 24, 2024
@mr0re1 mr0re1 self-requested a review November 27, 2024 02:48
@mr0re1 mr0re1 self-assigned this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants