Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move changes from experimental to develop #3265

Draft
wants to merge 49 commits into
base: develop
Choose a base branch
from
Draft

Conversation

annuay-google
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

cdunbar13 and others added 30 commits August 26, 2024 15:02
Adding documentation and moving RDMA module to community

Updated for new version of guest_accelerator
Adding new network features to branch
Update to RDMA VPC for reducing repeated code
RDMA Support in GKE Blueprints
Experimental Networking Features for GKE
Remove the rdma_subnetwork_name_prefix output from rdma-vpc module
rdma-vpc update and develop -> experimental merge
@annuay-google annuay-google reopened this Nov 15, 2024
@annuay-google annuay-google changed the title [Please do not review or merge] Move changes from experimental to develop Nov 15, 2024
@annuay-google annuay-google marked this pull request as draft November 15, 2024 18:30
@@ -43,7 +43,7 @@ locals {

# INSTANCE TEMPLATE
module "slurm_controller_template" {
source = "github.com/GoogleCloudPlatform/slurm-gcp.git//terraform/slurm_cluster/modules/slurm_instance_template?ref=6.8.5"
source = "github.com/GoogleCloudPlatform/slurm-gcp.git//terraform/slurm_cluster/modules/slurm_instance_template?ref=b0575ab"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Slurm-gcp repo need to be migrated first and tagged.

@annuay-google annuay-google changed the base branch from develop to main November 18, 2024 20:18
@annuay-google annuay-google changed the base branch from main to develop November 18, 2024 20:18
@tpdownes tpdownes mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants