-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HCatalog and Pig #114
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
============================================
- Coverage 80.40% 0.00% -80.41%
============================================
Files 38 74 +36
Lines 1536 2276 +740
Branches 192 281 +89
============================================
- Hits 1235 0 -1235
- Misses 207 2276 +2069
+ Partials 94 0 -94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yigress I've removed all the Spark code from this PR. We can leave the Spark stuff aside for now. Let me know what you think about this one! |
I tried to run a pig example but got error
tried to debug a little but couldn't figure out why NPE. the code logic seems okay, but unless the jobconf somehow got cleaned up |
I have a It looks like somehow the |
the if seems executed, that is why i suspect maybe somehow the conf get swapped somewhere |
The Perhaps |
...mmon/src/main/java/com/google/cloud/hive/bigquery/connector/output/OutputCommitterUtils.java
Outdated
Show resolved
Hide resolved
...mmon/src/main/java/com/google/cloud/hive/bigquery/connector/output/OutputCommitterUtils.java
Outdated
Show resolved
Hide resolved
...ctor-common/src/main/java/com/google/cloud/hive/bigquery/connector/utils/hive/HiveUtils.java
Outdated
Show resolved
Hide resolved
LGTM + 1 |
No description provided.