This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
Use for instead of forEach and reset array instead of allocating new #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes everything a little faster in benchmarks, however it uses more bytes.
Lxxyx
reviewed
Sep 22, 2018
| @@ -31,7 +31,8 @@ const createQueueMicrotaskViaMutationObserver = () => { | |||
| let microtaskQueue = []; | |||
| const observer = new MutationObserver(() => { | |||
| microtaskQueue.forEach((microtask) => microtask()); | |||
| microtaskQueue = []; | |||
| for (let x = 0; x < microtaskQueue.length; ++x) microtaskQueue[x](); | |||
There was a problem hiding this comment.
seems microtaskQueue run twice. You forget delete forEach tasks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes everything a little faster in benchmarks, however it uses more bytes.
If you want to take the trade-off (slightly more bytes, but no new array allocation needed) for https://github.com/GoogleChromeLabs/idlize/blob/master/IdleQueue.mjs as well I can PR too.