Bare minimum changes to demo to get errors resolved #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready to merge? |
I'm happy to merge it, but it just stops the errors, it doesn't make the demo work yet, that can be follow up PRs but I haven't had time to implement more yet. |
|
I was planning on picking up the demo as soon as I get my other PRs posted, I want to add an overlay demo as well. So if you want to merge this, I can continue from there! |
vilhalmer
approved these changes
Nov 20, 2024
fire
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have time right now to do a full update on the demo to make all the features work, but with Godot XR Tools removed the demo couldn't be loaded anymore.
This PR simply disjoints it from XR Tools.
Will see if I can find some spare time to get some basic functionality back in but that will need to be a separate PR.