Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change release CI to only build on tag #152

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

BastiaanOlij
Copy link
Member

This changes the release steps in our github action to only build when tagged (i.e. we manually create a release) instead of whenever something is merged into master. This way we can properly structure alpha and beta releases.
These changes also prevent the release info from being overwritten.

@BastiaanOlij BastiaanOlij added this to the 2.0.0 milestone Nov 18, 2024
@vilhalmer
Copy link
Collaborator

This does make it even harder to test CI changes, is there some established pattern for GitHub Actions to build for PRs that change the action config itself?

@beniwtv
Copy link
Collaborator

beniwtv commented Nov 20, 2024

I think originally I set it this way as we were getting requests for kind of "nightly" builds that people could test. However, this was also during times when this plugin was still under heavy development.

@vilhalmer
Copy link
Collaborator

I'm not personally using the CI-generated builds for anything, so I don't mind either way.

@BastiaanOlij
Copy link
Member Author

BastiaanOlij commented Nov 20, 2024

This does make it even harder to test CI changes, is there some established pattern for GitHub Actions to build for PRs that change the action config itself?

The artifacts are still uploaded to the actions run for each PR. So if you go to the checks tab and then click on the "build to push", you'll find them for download there. I need to look into this a little closer because it should be possible to even make them downloadable from the checks tab itself, that's definitely how things are setup for the main Godot repo.

I think originally I set it this way as we were getting requests for kind of "nightly" builds that people could test. However, this was also during times when this plugin was still under heavy development.

That's what I followed for awhile as well, but it just fills the releases page with so much history, it's impossible to find real pre-releases.

@BastiaanOlij BastiaanOlij merged commit 47db688 into GodotVR:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants