Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amendment #37

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Amendment #37

merged 1 commit into from
Oct 10, 2023

Conversation

janvanmansum
Copy link

As discussed with @qqmyers changing DatasetFieldType.isControlledVocabulary() to return allowControlledVocabulary instead of accessing the database to see if the list of terms is non-empty. This gets rid of NPE's in EclipseLink's AbstractSession.executeDeferredEvents, e.g.,

  java.lang.NullPointerException
        at org.eclipse.persistence.internal.sessions.AbstractSession.executeDeferredEvents(AbstractSession.java:1534)
        at org.eclipse.persistence.internal.sessions.UnitOfWorkImpl.internalExecuteQuery(UnitOfWorkImpl.java:3005)
        at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1898)
        at org.eclipse.persistence.internal.sessions.AbstractSession.executeQuery(AbstractSession.java:1880)

which are presumably caused by using the EntityManager from a thread that is not supposed to use it. See also: https://stackoverflow.com/questions/73974404/npe-in-eclipse-link-abstractsession-executedeferredeventsabstractsession-java1

@janvanmansum
Changed DatasetFieldType.isControlledVocabulary() to return allowCont…
1c7bc24 
…rolledVocabulary instead of looking up complete list of terms to see if it is empty
@janvanmansum janvanmansum mentioned this pull request Oct 10, 2023
Merged
@qqmyers qqmyers merged commit e6ef39c into GlobalDataverseCommunityConsortium:IQSS/9983-missing_unique_constraints Oct 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janvanmansum @qqmyers