Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate GDAL and RichDEM ground truths for xDEM tests #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vschaffn
Copy link

@vschaffn vschaffn commented Jan 9, 2025

Resolves #2.
Completes GlacioHack/xdem#675.

Description:

The goal of this PR is to relocate the xDEM test codes that rely on GDAL and RichDEM, so that ground truths can be generated for use in xDEM tests. The ultimate objective is to eliminate all dependencies on GDAL and RichDEM within xDEM.

Changes:

  • generate_ground_truth_gdal.py: This script generates ground truths using the GDAL package, which are then used in xDEM tests.
  • generate_ground_truth_richdem.py: This script generates ground truths using the RichDEM package, which are then used in xDEM tests.

Ground truths generated from GDAL and RichDEM are stored in the test_data directory in .tif format.

@vschaffn vschaffn changed the title Generate GDAL and RichDEM ground truth for xDEM tests Generate GDAL and RichDEM ground truths for xDEM tests Jan 9, 2025
@duboise-cnes
Copy link
Member

duboise-cnes commented Jan 9, 2025

The PR code seems ok. A question: another PR is needed afterwards in XDEM code to use generated reference data ? Can you put the link of it if available ?

otherwise seems ok for me. Maybe the real check of these issues is the PR in xdem running unit tests the same way, hence my question

@vschaffn @adebardo

@vschaffn
Copy link
Author

vschaffn commented Jan 9, 2025

The PR code seems ok. A question: another PR is needed afterwards in XDEM code to use generated reference data ? Can you put the link of it if available ?

otherwise seems ok for me. Maybe the real check of these issues is the PR in xdem running unit tests the same way, hence my question

@vschaffn @adebardo

You sent this just before I create the PR in xDEM 😄
GlacioHack/xdem#675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Richdem et gdal data generation
2 participants