#88 - Remove unused/risky range early exit.

Gizra · May 25, 2017 · df13f62 · df13f62
1 parent fc938e3
commit df13f62
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/message_subscribe.module b/message_subscribe.module
@@ -57,18 +57,9 @@ function message_subscribe_message_subscribe_get_subscribers(MessageInterface $m
     $result = $query->execute();
 
     foreach ($result as $row) {
-
       $uids[$row->uid] = !empty($uids[$row->uid]) ? $uids[$row->uid] : new DeliveryCandidate([], [], $row->uid);
       // Register the flag name.
       $uids[$row->uid]->addFlag($row->flag_id);
-
-      if ($range) {
-        --$range;
-        if ($range == 0) {
-          // We've reach the requested item.
-          return $uids;
-        }
-      }
     }
   }
 

diff --git a/src/Subscribers.php b/src/Subscribers.php
@@ -134,10 +134,6 @@ public function sendMessage(EntityInterface $entity, MessageInterface $message,
       $message->save();
     }
 
-    if ($use_queue) {
-      $id = $entity->id();
-    }
-
     if ($use_queue && empty($subscribe_options['queue'])) {
       if (empty($message->id())) {
         throw new MessageSubscribeException('Cannot add a non-saved message to the queue.');